Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): do not apply socket-init-workaround to ipc socket #27779

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 22, 2025

This PR resolves 2 issues of Socket class of node compat (both are related to playwright)

Currently browser.launch() of playwright is not working. browser.launch opens PipeTransport (which is based on Pipe/IPC socket) with the browser process. But that pipe doesn't start reading the data because of the workaround #27662 (which pauses the socket at the beginning if it's from playwright-core). This PR fixes this issue by checking whether the given handle is ipc handle or not.

Another issue is that sock-init-workaround for TLS connection stopped working at #27707 because of the changes of TLS socket initialization steps. This change fixes the issue by correctly returning the function in workaround path.

The added case specs::npm::playwright_compat checks both fixes with actual playwright and playwright-core packages.

browser.launch issues
closes #16899
closes #27623

https.request issue
closes #27658

  • write test case

@kt3k kt3k added the ci-draft Run the CI on draft PRs. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-draft Run the CI on draft PRs.
Projects
None yet
1 participant