fix(ext/net): enable EDNS0 for Deno.resolveDns #27735
Open
+126
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petamoriken
reviewed
Jan 21, 2025
| @@ -662,6 +662,8 @@ where | |||
| system_conf::read_system_conf()? | |||
| }; | |||
|
|
|||
| opts.edns0 = true; | |||
There was a problem hiding this comment.
nits: Please add a comment here 🙇
|
hmm, looks like the DNS mock server implementation in node compat test utils are not compatible with hickory-dns resolver with EDNS0 enabled 😓 I need to figure out what the exact issue with those utils.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables EDNS0 option in resolver.lookup call. This allows about x2 message size in DNS udp response, and makes the issue like #27670 less likely to happen.
related issue in hickory-dns hickory-dns/hickory-dns#2140
closes #27670