-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery - context menu - 2nd Attempt #985
Conversation
I just had a short check on my phone. It looks great, video works too. What is missing is support for gif files. At least the first image of an gif should be shown, if previewing gifs is not possible. Currently there's a white image shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment
great! some ui things:
to the general understanding:
|
The complexity is only that we have to cover both context-menu-styles as long we support iOS12 and lower. |
@r10s I could not find any suitable confirm-delete-string. Any idea? |
we're getting closer :) some more things, for ios 11, 12:
you can test this eg. in "iPhone 8 (iOS 12.2)" emulator things for ios 13+:
|
b61b745
to
6994533
Compare
99212b2
to
5fb89cd
Compare
@r10s Ok, I am done for now. |
There's an unresolved merge conflict and unfortunately also new merge conflcts with latest master that need to be resolved, too. |
…ow takes generic type
aa0bbed
to
e3762a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I fixed the merge conflict and removed the controls from the video preview, because a tap on any item within the preview will open the preview controller, so the controls can never be triggered. It's now the same UI as in the iOS Gallery wrt. video previews.
closes #944
closes #891
Since MessageKit-files were deleted I was not able to rebase properly, so I had to rebase "manually" using this branch.
This PR:
contextMenuProvider
to generate legacy and new styled context menusDocumentGalleryController
(modern context menu uses default preview)Gallery did not look nice in landscape on devices with notch. I did a quick fix in this PR too.
To test:
replaces #952