chore: use flags for apple arm64 #3213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
force-pushed
the
chore/apple-sillicon-flags
branch
from
193eec2 to
6fe298f
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
chore/apple-sillicon-flags
branch
from
6fe298f to
99e4053
Compare
ion-elgreco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3213 +/- ##
=======================================
Coverage 72.10% 72.10%
=======================================
Files 138 138
Lines 45320 45320
Branches 45320 45320
=======================================
+ Hits 32678 32680 +2
+ Misses 10567 10562 -5
- Partials 2075 2078 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These flags were missing causing my compilations to not being incremental anymore.
Combined with this I still have to provide explicit flags in the compilation:
Created an issue for this explicitness during maturin develop here: PyO3/maturin#2479