Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update snapshot after conflict check #3205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ion-elgreco
Copy link
Collaborator

Description

Currently with multiple retries we would conflict check the same versions because our starting point (read_snapshot) is never updated after conflict resolution, this could be costly with many concurrent writers.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Feb 11, 2025
@ion-elgreco ion-elgreco force-pushed the fix/advance_after_conflict_check branch from eef5f72 to 8df1889 Compare February 11, 2025 11:03
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.09%. Comparing base (b3efdfc) to head (0cec998).

Files with missing lines Patch % Lines
crates/core/src/operations/transaction/mod.rs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3205      +/-   ##
==========================================
- Coverage   72.10%   72.09%   -0.02%     
==========================================
  Files         138      138              
  Lines       45320    45323       +3     
  Branches    45320    45323       +3     
==========================================
- Hits        32678    32675       -3     
- Misses      10567    10568       +1     
- Partials     2075     2080       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco force-pushed the fix/advance_after_conflict_check branch from 8df1889 to 0cec998 Compare February 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant