feat: return metrics about the commit #3202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HawaiianSpork
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
HawaiianSpork
force-pushed
the
commit_metrics
branch
2 times, most recently
from
2646c02 to
ebde039
Compare
HawaiianSpork
changed the title
Post commit now contains the number of retries it took to do the commit and FinalizeCommit now contains number of retries, whether there was a checkpoint created and number of log files cleaned-up. Signed-off-by: Michael Maletich <[email protected]>
HawaiianSpork
force-pushed
the
commit_metrics
branch
from
ebde039 to
539e6ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
- Coverage 72.18% 72.16% -0.02%
==========================================
Files 138 138
Lines 45292 45309 +17
Branches 45292 45309 +17
==========================================
+ Hits 32694 32698 +4
- Misses 10535 10536 +1
- Partials 2063 2075 +12 ☔ View full report in Codecov by Sentry. |
|
@HawaiianSpork can you fix the fmt and add a small test, and then rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PostCommitnow contains the number of retries it took to do the commit andFinalizeCommitnow contains number of retries, whether there was a checkpoint created and number of log files cleaned-up.This can be useful for consumers to track if the retries are approaching the maximum retry count. It also allows consumers to correlate commit times with the amount of work being done for that commit.