Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inline format args to improve readability #3154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jan 21, 2025

Using this command, fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.

cargo clippy --all-targets --workspace -- -D clippy::uninlined_format_args

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 21, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 43.69748% with 67 lines in your changes missing coverage. Please review.

Project coverage is 72.21%. Comparing base (d563e10) to head (1329db9).

Files with missing lines Patch % Lines
crates/core/src/kernel/models/actions.rs 22.22% 6 Missing and 1 partial ⚠️
crates/benchmarks/src/bin/merge.rs 0.00% 5 Missing ⚠️
crates/core/src/delta_datafusion/mod.rs 16.66% 5 Missing ⚠️
crates/core/src/table/builder.rs 16.66% 5 Missing ⚠️
crates/core/src/table/state_arrow.rs 20.00% 4 Missing ⚠️
crates/aws/src/lib.rs 0.00% 3 Missing ⚠️
crates/core/src/kernel/models/schema.rs 0.00% 3 Missing ⚠️
crates/core/src/operations/cast/merge_schema.rs 0.00% 3 Missing ⚠️
crates/core/src/writer/record_batch.rs 0.00% 0 Missing and 3 partials ⚠️
crates/lakefs/src/logstore.rs 40.00% 3 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
+ Coverage   72.15%   72.21%   +0.06%     
==========================================
  Files         138      138              
  Lines       45365    45272      -93     
  Branches    45365    45272      -93     
==========================================
- Hits        32731    32695      -36     
+ Misses      10561    10506      -55     
+ Partials     2073     2071       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Using this command, fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.

```
cargo clippy --all-targets --workspace -- -D clippy::uninlined_format_args
```

Signed-off-by: Yuri Astrakhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant