Adding incentive allocation to schema. #63
Conversation
Update descriptions
Update descriptions
Update descriptions.
| | token_address | The token address of the pool token at token_index. | string | | ||
| | token_symbol | The symbol of the pool token. | string | | ||
| | token_decimals | The decimals of the pool token. | string | | ||
| | token_decimals | The decimals of the pool token. | int | |
There was a problem hiding this comment.
Need to make this change in the schema.json, then autogen the md file
There was a problem hiding this comment.
Oh I see, this was just from autogenerating, ignore my comment then
| "log_index" | ||
| ], | ||
| "description": "Transactional data on user level incentives claimed data.", | ||
| "description": "Pool level allocations for an incentive program period.", |
There was a problem hiding this comment.
This table looks like transactional data to me, not pool level
There was a problem hiding this comment.
Just flipflopped the descriptions
There was a problem hiding this comment.
this is pool level, this is the schema for our allocations, not really related to DOP, just wanted to make sure this is maintained somewhere
| "description": "The standard chain id.", | ||
| "type": "int" | ||
| }, | ||
| "program_name": { |
There was a problem hiding this comment.
Usually this is something we add in after the fact, in the DOP pipeline
There was a problem hiding this comment.
this is for non DOP incentives, this is for our allocations at the pool level, so this will come out of a DBT model (or have to be added manually, I am mainly keeping it here for our records)
| ], | ||
| "description": "Transactional data on user level incentives claimed data.", | ||
| "properties": { | ||
| "reward_token": { |
There was a problem hiding this comment.
| "reward_token": { | |
| "reward_token_address": { |
| "tableName": "pool_level_incentive_allocations", | ||
| "aggregation": "general_pools", | ||
| "uniqueKey": [ | ||
| "pool_address" |
There was a problem hiding this comment.
We don't really use this right now, but to be proper the unique key should be pool_address and a timestamp field. You could add block_date on the end date of the period and use that.
melotik
left a comment
melotik
left a comment
There was a problem hiding this comment.
lgtm, but need to address comments before merging
No description provided.