Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopowermax updates to support powermax unit tests #93

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

bharathsreekanth
Copy link
Contributor

@bharathsreekanth bharathsreekanth commented Feb 25, 2025

Description

Minor enhancements to gopowermax to aid csi-powermax tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Unit tested csi-powermax with commit ID from these changes.

@@ -129,6 +129,12 @@ var Data struct {
FileIntIDtoFileInterface map[string]*types.FileInterface
}

var Filters = new(filters)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable accessed from unit tests in csi-powermax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@bharathsreekanth bharathsreekanth merged commit 14832df into main Feb 25, 2025
6 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/service-uts branch February 25, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants