-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage #92
Merged
Merged
+1,957
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reset() func refactored to not have nested mutex locking and unlocking, but still lock at func root. - Added a func for safe variable injection by test code.
- making global client vars part of the client struct to avoid race conditions
- Exported functions should lock the mutex before calling unexported funcs. - Unexported funcs should only call unexported funcs to avoid deadlock caused by trying to lock an already locked mutex in the same thread.
falfaroc
previously approved these changes
Feb 21, 2025
donatwork
previously approved these changes
Feb 21, 2025
ChristianAtDell
approved these changes
Feb 25, 2025
donatwork
approved these changes
Feb 25, 2025
falfaroc
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the mock server to address data races around accessing the global struct of "Induced errors".
Unit tests executed by csi-powermax have a dependency on the mock PowerMax server in
mock.go
. This server handles requests made by csi-powermax code when executing its unit tests. In order to induce errors, there is a global set of boolean vars within the mock server that is set by csi-powermax unit test code, and also read by the running server, leading to data races.To resolve this, functions that read or otherwise modify the global vars have been unexported, and associated exported functions with the same name and func signature will call these unexported funcs, making sure to acquire the lock first. If necessary, unexported funcs should only call other unexported funcs to avoid deadlock.
Increasing unit test coverage.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration