This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Add support for StatefulSets #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbehar
requested review from
jeremyrickard,
krancour and
yaron2
as code owners
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 57.3% 56.65% -0.66%
==========================================
Files 11 11
Lines 623 639 +16
==========================================
+ Hits 357 362 +5
- Misses 237 248 +11
Partials 29 29
Continue to review full report at Codecov.
|
|
@vbehar this has some merge conflicts after support for shorter DNS names was merged. |
|
yes thanks, I'll fix them |
With this change, Osiris can now manage both Deployments and StatefulSets. I introduced a new service annotation `osiris.deislabs.io/statefulset` to link a service with its statefulset, otherwise everything works the same as with Deployments. Internally, I tried to avoid duplicated code, and introduced a `kind` parameter to make a distinction between deployments and statefulsets.
|
ok, rebased on master |
krancour
reviewed
Oct 15, 2019
krancour
reviewed
Oct 18, 2019
|
Need rebase after recent merge. |
|
@krancour ok, it's been rebased after the recent merges. |
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
apply deislabs#43 With this change, Osiris can now manage both Deployments and StatefulSets. I introduced a new service annotation `osiris.deislabs.io/statefulset` to link a service with its statefulset, otherwise everything works the same as with Deployments. Internally, I tried to avoid duplicated code, and introduced a `kind` parameter to make a distinction between deployments and statefulsets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, Osiris can now manage both Deployments and StatefulSets.
I introduced a new service annotation
osiris.deislabs.io/statefulsetto link a service with its statefulset, otherwise everything works the same as with Deployments.Internally, I tried to avoid duplicated code, and introduced a
kindparameter to make a distinction between deployments and statefulsets.