Skip to content

Remove telemetry cells #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove telemetry cells #400

wants to merge 1 commit into from

Conversation

bilgeyucel
Copy link
Contributor

No description provided.

@bilgeyucel bilgeyucel requested a review from julian-risch May 14, 2025 11:48
@bilgeyucel bilgeyucel self-assigned this May 14, 2025
@bilgeyucel bilgeyucel requested a review from a team as a code owner May 14, 2025 11:48
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

julian-risch
julian-risch requested changes May 14, 2025
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of unrelated changes (10k+ lines) in tutorials/44_Creating_Custom_SuperComponents.ipynb and in tutorials/41_Query_Classification_with_TransformersTextRouter_and_TransformersZeroShotTextRouter.ipynb
Let's revert those changes and only remove the telemetry cell. All other files look good to me!

@bilgeyucel
Copy link
Contributor Author

There are lots of unrelated changes (10k+ lines) in tutorials/44_Creating_Custom_SuperComponents.ipynb and in tutorials/41_Query_Classification_with_TransformersTextRouter_and_TransformersZeroShotTextRouter.ipynb Let's revert those changes and only remove the telemetry cell. All other files look good to me!

Those changes are due to formatting by pre-commit hooks. There's nothing we add or remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@bilgeyucel bilgeyucel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilgeyucel @julian-risch