feat: add async support for CohereDocumentEmbedder

[srini047]

Related Issues

• fixes Add run_async to CohereDocumentEmbedder #1507

Proposed Changes:

Added run_async conversion for CohereDocumentEmbedder

How did you test it?

Added a separate test case for testing asyc feature.

Notes for the reviewer

To be merged after #1873 since dependencies are present here.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

[sjrl]

Hey @vblagoje let's wait for this PR to be reviewed and merged before making a release so we can include the run_async for the CohereTextEmbedder (which was added here) and CohereDocumentEmbedder in one go.

[srini047]

Hey @vblagoje let's wait for this PR to be reviewed and merged before making a release so we can include the run_async for the CohereTextEmbedder (which was added here) and CohereDocumentEmbedder in one go.

Have raised PRs for Ollama integration as well. Both document and text embedder in case that's in eye for the next release.

[vblagoje]

Hey @srini047 left some initial feedback - minor issues, but worth addressing imho

[srini047]

Hey @srini047 left some initial feedback - minor issues, but worth addressing imho

Fixed it @vblagoje

[vblagoje]

Looks good, thanks for this contribution @srini047

missed an issue

[vblagoje]

@srini047 a small favour, while we are at it:

• initialize AsyncClient in init, don't use asserts raise meaningful errors (see other components)
• in both run methods use async client
  • in run sync use asyncio to bridge
  • in run async use current approach
• Flag with log warn use_async_client param as deprecated and ignore it

This is a legacy code before we have async method and we might as well remove it now 👏

[srini047]

@srini047 a small favour, while we are at it:

• initialize AsyncClient in init, don't use asserts raise meaningful errors (see other components)

• in both run methods use async client

  • in run sync use asyncio to bridge
  • in run async use current approach

• Flag with log warn use_async_client param as deprecated and ignore it

This is a legacy code before we have async method and we might as well remove it now 👏

@vblagoje
[EDIT] Addressed the first concern.
For the second/third point I think its better to address it seperately because this logic is also present in the CohereTextEmbedder as well. So I feel a refactor of Cohere integration on the whole in this sync/async area should be better. WDYT?

[vblagoje]

Yes, very good point let's just resolve the test failures now and integrate this one

[anakin87]

@srini047 thanks again for the contribution!

I'm now merging this PR and then rebasing #1946 on your work.

We agreed on this