Fix Linear Layer Bias Initialization #556
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed bias initialization in the Linear class by using
out_features
instead of the undefinedself.part_out_features
. This fix ensures proper bias initialization for all linear layers in the model.Changes Made
Linear.__init__
to useout_features
parameter for bias tensor initializationWhy This Change is Needed
The previous implementation tried to access
self.part_out_features
which is only defined in child classes (ColumnParallelLinear), causing potential issues when the Linear class is used directly. Usingout_features
is the correct approach as it's always available and matches the weight tensor's output dimension.Testing Done
Checklist