Added optional GPU Memory Logging #459
Open
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an optional --log-gpu-memory command-line flag in generate.py to log GPU memory usage at key points (immediately after loading the model, before generation, and after generation). By default, logging is disabled, so there is no impact on users who do not require memory tracking.
Changes :
Added a --log-gpu-memory argument.
Conditionally log GPU memory allocated/reserved at each relevant inference stage.
Rationale :
Simplifies troubleshooting for users running large models on limited GPU VRAM.
Maintains existing code paths when the flag is not used.
Testing :
Verified correct parsing of the new flag in local setups.
Observed expected memory logs appear only when --log-gpu-memory is enabled.
No additional dependencies or performance overhead for users who opt out of memory logging.