-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add orbital mapping constants for ABACUS, DeePTB, and OPENMX #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add orbital number mappings and transformation matrices for ABACUS, DeePTB, and OPENMX DFT codes. These constants define the magnetic quantum number ordering and provide conversion matrices between different code conventions, enabling proper orbital basis transformations.
Updated variable name in constants.py to align with the project's naming convention and reflect the transition from DeePTB to DFTIO. This change improves code clarity and maintains consistency across the codebase.
📝 WalkthroughWalkthroughAdded new orbital number mappings for ABACUS, DeePTB, and OpenMX platforms defining per-angular-momentum lists. Introduced new OpenMX2DFTIO mapping with 2D-FFT index-to-identity configuration. Expanded ABACUS2DFTIO public mapping with updated index configurations across multiple orbital blocks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.py📄 CodeRabbit inference engine (GEMINI.md)
Files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 40.35% 40.40% +0.04%
==========================================
Files 43 43
Lines 4864 4868 +4
==========================================
+ Hits 1963 1967 +4
Misses 2901 2901
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add orbital number mappings and transformation matrices for ABACUS, DeePTB, and OPENMX DFT codes. These constants define the magnetic quantum number ordering and provide conversion matrices between different code conventions, enabling proper orbital basis transformations.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.