Skip to content

Conversation

@wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Aug 17, 2025

Allows subsetting without requiring all arguments. Backwards compatible with original behavior.

If a filter is provided without providing the relevant data array, an error is raised.

If the data arrays are not the same shape, an error is raised

Filters and data for the time variable are cast to numpy datetime64 first to allow, e.g., subsetting an array of numpy datetime64 using a filter of datetime objects.

Fixes #39

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.34%. Comparing base (97f8aaa) to head (e246fbc).

Files with missing lines Patch % Lines
pyxlma/plot/xlma_plot_feature.py 83.33% 8 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   73.20%   73.34%   +0.14%     
==========================================
  Files          16       16              
  Lines        2086     2127      +41     
==========================================
+ Hits         1527     1560      +33     
- Misses        559      567       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subset should really be keyword arguments for both the inputs and limits

2 participants