Skip to content

Commit

Permalink
[vllm] leverage passthrough for generation_config engine argument (#2727
Browse files Browse the repository at this point in the history
)
  • Loading branch information
siddvenk authored Feb 6, 2025
1 parent ed821e5 commit d23acca
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class VllmRbProperties(Properties):
# Neuron vLLM properties
device: str = 'auto'
preloaded_model: Optional[Any] = None
generation_config: Optional[Any] = None
override_neuron_config: Optional[Dict] = None

# Non engine arg properties
Expand Down Expand Up @@ -237,7 +236,6 @@ def get_engine_args(self) -> EngineArgs:
# These neuron configs are not implemented in the vllm arg parser
if self.device == 'neuron':
setattr(engine_args, 'preloaded_model', self.preloaded_model)
setattr(engine_args, 'generation_config', self.generation_config)
setattr(engine_args, 'override_neuron_config',
self.override_neuron_config)
return engine_args
Expand Down

0 comments on commit d23acca

Please sign in to comment.