Verify that subscription request comes from known AWS account #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deep-c
reviewed
Mar 18, 2025
| """ | ||
| if hasattr(settings, 'AWS_ACCOUNT_ID'): | ||
| arn = payload['TopicArn'].split(':')[4] | ||
| print(arn) |
There was a problem hiding this comment.
nitpick: dont think this is necessary. Could use logger.debug otherwise
|
Thanks kwood, this is indeed useful. Ive just opened a PR to update the repo based on a fork. If you could make your changes based on that branch we can merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this package validates that subscription requests are signed by AWS, but this allows any account on AWS to create a topic and start sending messages to an endpoint.
This is a potential security problem — if an attacker can discover the URL for an endpoint, they can create their own topics that write to them, and the subscription and subsequent messages will be accepted.
This PR creates a way to deny subscription requests that aren't coming from a known AWS account, configurable in the Django settings. It also introduces an easy way to customize this behavior, by overriding the
should_confirm_subscriptionmethod.If there's interest in merging this PR, I'd be happy to write some documentation for it.
Note that I had to remove the
nose-testsdependency — that library is no longer maintained, and./manage.py testworks out of the box now.