-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubevirt): migration disk serial #690
Open
yaroslavborbat
wants to merge
1
commit into
main
Choose a base branch
from
fix/kubevirt/backport-disk-serial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+464
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
changed the title
fix(kubevirt): backport disk serial
fix(kubevirt): migration disk serial
Feb 3, 2025
yaroslavborbat
force-pushed
the
fix/kubevirt/backport-disk-serial
branch
2 times, most recently
from
February 3, 2025 12:26
d5ef5b8
to
6435099
Compare
Isteb4k
requested changes
Feb 3, 2025
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
Outdated
Show resolved
Hide resolved
yaroslavborbat
force-pushed
the
fix/kubevirt/backport-disk-serial
branch
4 times, most recently
from
February 4, 2025 11:19
7e765ae
to
4013ade
Compare
Isteb4k
previously approved these changes
Feb 4, 2025
yaroslavborbat
force-pushed
the
fix/kubevirt/backport-disk-serial
branch
from
February 4, 2025 14:37
bb53795
to
597b972
Compare
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
fix/kubevirt/backport-disk-serial
branch
from
February 4, 2025 14:38
597b972
to
18be4fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix disk serial handling for successful migration:
Previously, we set the disk serial to match the disk name, relying on Kubernetes to ensure the uniqueness of names. However, after this commit on QEMU, we can no longer do this, as QEMU no longer truncates the serial to 36 characters and now returns an error. We must handle the truncation ourselves. However, truncation does not guarantee uniqueness, so we switched to generating an MD5 hash of the disk name. The MD5 hash is easy to reproduce and fits the required 32-character length.
To ensure a successful migration, existing
kvvm
andkvvmi
resources need to be patched to reflect the new serial format.Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries