Feat/vmbda reattach#18
Merged
Merged
Conversation
mrwesadex-flant
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, validated API for reattaching existing virtual disks to virtual machines, standardizes naming to Go conventions, and updates documentation to reflect these changes. The main focus is on making the disk reattachment process clearer, safer, and better documented for both developers and users.
Virtual disk reattachment improvements
ReattachVirtualDiskToVMfunction inpkg/kubernetes/virtualdisk.gothat allows attaching an existingVirtualDiskto a VM using explicit resource names. This function uses a newVirtualDiskReattachmentConfigstruct for input validation, ensuring all required fields are provided before proceeding.ReattachVirtualDiskToVM), improving API consistency.Documentation updates
ReattachVirtualDiskToVMfunction and its configuration struct indocs/FUNCTIONS_GLOSSARY.md, making it easier for users to discover and use the new API.docs/WORKLOG.mdsummarizing the API addition, normalization, and documentation sync.