Skip to content

feat: mark request id as fulfilled instead of deleting them#103

Merged
aleortega merged 1 commit intomainfrom
feat/dangling-request-ids
Feb 18, 2026
Merged

feat: mark request id as fulfilled instead of deleting them#103
aleortega merged 1 commit intomainfrom
feat/dangling-request-ids

Conversation

@aleortega
Copy link
Member

This PR updates the flow of request id confirmation and expiration:

  • It starts storing the request ids in Redis instead of in-memory to prevent loosing requests ids upon service restarts
  • It marks them as fulfilled instead of removing them from the catch causing further 404 Not Found when they were already consumed

Copy link

@MauroCicerchia MauroCicerchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aleortega aleortega merged commit 99e86db into main Feb 18, 2026
1 check passed
@aleortega aleortega deleted the feat/dangling-request-ids branch February 18, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments