feat: use Varnish only for web:80, remove novarnish subdomains, fixes #32
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Varnish should run only for
web:80, not for all ports.This PR changes the logic to route
web:80through Varnish, while leaving everything else (Mailpit,web_extra_exposed_ports) unchanged.This removes the need for
novarnish.*subdomains.Manual Testing Instructions
Prepare project:
Install add-on:
And test it:
Only this url should have Varnish headers:
Mailpit: no Varnish headers:
web_extra_exposed_ports: no Varnish headers:
Automated Testing Overview
I added test coverage for everything.
Release/Deployment Notes
This should be released as major v1.0.0.