Skip to content

Fix #183: .apply skips last path #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apiwat-chantawibul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #183: .apply skips last path #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ JSONPath.prototype.apply = function(obj, string, fn) {
});

nodes.forEach(function(node) {
var key = node.path.pop();
var parent = this.value(obj, this.stringify(node.path));
var key = node.path.slice(-1);
var parent = this.value(obj, this.stringify(node.path.slice(0, -1)));
var val = node.value = fn.call(obj, parent[key]);
parent[key] = val;
}, this);
Expand Down
13 changes: 13 additions & 0 deletions test/sugar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var assert = require('assert');
var jp = require('../');
var util = require('util');
var storeData = require('./data/store.json');

suite('sugar', function() {

Expand All @@ -25,6 +26,18 @@ suite('sugar', function() {
assert.deepEqual(data.a.b, [{c: [3, 2]}, 1]);
});

test('apply method reports matched nodes', function() {
var results = jp.apply(storeData, '$..author', function(value) {
return value.toUpperCase();
});
assert.deepEqual(results, [
{ path: ['$', 'store', 'book', 0, 'author'], value: 'NIGEL REES' },
{ path: ['$', 'store', 'book', 1, 'author'], value: 'EVELYN WAUGH' },
{ path: ['$', 'store', 'book', 2, 'author'], value: 'HERMAN MELVILLE' },
{ path: ['$', 'store', 'book', 3, 'author'], value: 'J. R. R. TOLKIEN' }
]);
});

test('value method gets us a value', function() {
var data = { a: 1, b: 2, c: 3, z: { a: 100, b: 200 } };
var b = jp.value(data, '$..b')
Expand Down