Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use tool key name without version when removing tool from database #867

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use tool key name without version when removing tool from database #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shinkai-bin/shinkai-node/src/network/v2_api/api_v2_commands_tools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,14 +2271,14 @@ impl Node {
return Ok(());
}
let tool_router_key = tool_router_key.unwrap();

let tool_key_name = tool_router_key.to_string_without_version();
let version = tool_router_key.version;

// Attempt to remove the playground tool first
let _ = db_write.remove_tool_playground(&tool_key);

// Remove the tool from the database
match db_write.remove_tool(&tool_key, version) {
match db_write.remove_tool(&tool_key_name, version) {
Ok(_) => {
let response = json!({ "status": "success", "message": "Tool and associated playground (if any) removed successfully" });
let _ = res.send(Ok(response)).await;
Expand Down