Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- feature: add uv #78

Merged
merged 9 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions docker-images/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ SHELL ["/bin/bash", "-c"]
RUN apt-get update && apt-get install -y chromium
ENV CHROME_PATH=/usr/bin/chromium

# Add python 3
RUN apt-get install -y python3 python3-pip python3-venv
RUN apt-get install -y curl

WORKDIR /app
RUN python3 -m venv cache/python-venv && source cache/python-venv/bin/activate && pip install pipreqs
RUN curl -LsSf https://astral.sh/uv/install.sh | sh
ENV PATH="/root/.local/bin:${PATH}"

RUN source $HOME/.local/bin/env && uv venv --seed cache/python-venv --python 3.13 && source cache/python-venv/bin/activate && uv pip install pipreqs

ENTRYPOINT ["/tini", "--"]
1 change: 1 addition & 0 deletions libs/shinkai-tools-runner/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ once_cell = { version = "1.20.2" }
env_logger = "0.11.5"
anyhow = { version = "1.0.93" }
chrono = { version = "0.4.38" }
whoami = "1.5"

[dev-dependencies]
rstest = "0.23.0"
Expand Down
8 changes: 1 addition & 7 deletions libs/shinkai-tools-runner/src/tools/deno_runner_options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ use super::{
pub struct DenoRunnerOptions {
pub context: ExecutionContext,
pub deno_binary_path: PathBuf,
pub python_binary_path: PathBuf,
pub code_runner_docker_image_name: String,
pub force_runner_type: Option<RunnerType>,
pub shinkai_node_location: ShinkaiNodeLocation,
Expand All @@ -19,17 +18,12 @@ impl Default for DenoRunnerOptions {
fn default() -> Self {
Self {
context: ExecutionContext::default(),
code_runner_docker_image_name: String::from("dcspark/shinkai-code-runner:0.9.0"),
code_runner_docker_image_name: String::from("dcspark/shinkai-code-runner:0.9.1"),
deno_binary_path: PathBuf::from(if cfg!(windows) {
"./shinkai-tools-runner-resources/deno.exe"
} else {
"./shinkai-tools-runner-resources/deno"
}),
python_binary_path: PathBuf::from(if cfg!(windows) {
"C://Users/agall/AppData/Local/Microsoft/WindowsApps/python"
} else {
"python"
}),
force_runner_type: None,
shinkai_node_location: ShinkaiNodeLocation {
protocol: String::from("http"),
Expand Down
143 changes: 98 additions & 45 deletions libs/shinkai-tools-runner/src/tools/python_runner.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use serde_json::Value;
use std::{
collections::HashMap,
path::{self, Path},
path::{self, Path, PathBuf},
sync::Arc,
time::Duration,
};
Expand Down Expand Up @@ -41,16 +41,67 @@ impl PythonRunner {
}
}

async fn ensure_python_venv(&self, venv_path: PathBuf) -> anyhow::Result<String> {
let uv_binary_path_at_host = path::absolute(self.options.uv_binary_path.clone())
.unwrap()
.to_string_lossy()
.to_string();

log::info!("Creating new venv with uv {:?}", venv_path);
let mut venv_command = tokio::process::Command::new(&uv_binary_path_at_host);
venv_command
.args([
"venv",
"--seed",
venv_path.to_str().unwrap(),
"--python",
"3.13",
])
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.kill_on_drop(true);
let venv_output = venv_command.spawn()?.wait_with_output().await?;
if !venv_output.status.success() {
return Err(anyhow::Error::new(std::io::Error::new(
std::io::ErrorKind::Other,
String::from_utf8(venv_output.stderr)?,
)));
}

log::info!("successfully created Python venv at {:?}", venv_path);

let python_path_at_venv = venv_path
.join(if cfg!(windows) { "Scripts" } else { "bin" })
.join(if cfg!(windows) {
"python.exe"
} else {
"python"
});

let python_binary_path = python_path_at_venv.to_string_lossy().to_string();
log::info!("python binary path: {}", python_binary_path);
Ok(python_binary_path)
}

pub async fn check(&self) -> anyhow::Result<Vec<String>> {
let execution_storage =
ExecutionStorage::new(self.code.clone(), self.options.context.clone());
execution_storage.init_for_python(None)?;

let binary_path = path::absolute(self.options.python_binary_path.clone())
.unwrap()
.to_string_lossy()
.to_string();
let mut command = tokio::process::Command::new(binary_path);
let python_binary_path: String = self
.ensure_python_venv(execution_storage.python_cache_folder_path())
.await?;

log::info!(
"using python from host at path: {:?}",
python_binary_path.clone()
);

let mut command = tokio::process::Command::new(python_binary_path);
println!(
"compiling code in folder: {}",
execution_storage.code_folder_path.to_str().unwrap()
);
command
.args([
"-m",
Expand Down Expand Up @@ -250,7 +301,10 @@ print("</shinkai-code-result>")
container_envs.push(String::from("-e"));
container_envs.push(format!("SHINKAI_MOUNT={}", mount_env));
container_envs.push(String::from("-e"));
container_envs.push(format!("SHINKAI_CONTEXT_ID={}", self.options.context.context_id));
container_envs.push(format!(
"SHINKAI_CONTEXT_ID={}",
self.options.context.context_id
));
container_envs.push(String::from("-e"));
container_envs.push(format!(
"SHINKAI_EXECUTION_ID={}",
Expand Down Expand Up @@ -278,7 +332,7 @@ print("</shinkai-code-result>")
.to_string_lossy()
.to_string();
let python_start_script = format!(
"source /app/cache/python-venv/bin/activate && python -m pipreqs.pipreqs --encoding utf-8 --force {} && pip install -r {}/requirements.txt && python {}",
"source /app/cache/python-venv/bin/activate && python -m pipreqs.pipreqs --encoding utf-8 --force {} && uv pip install -r {}/requirements.txt && python {}",
code_folder.clone().as_str(),
code_folder.clone().as_str(),
code_entrypoint.clone().as_str(),
Expand Down Expand Up @@ -384,45 +438,31 @@ print("</shinkai-code-result>")
let execution_storage = ExecutionStorage::new(code_files, self.options.context.clone());
execution_storage.init_for_python(None)?;

let python_binary_path_at_host = path::absolute(self.options.python_binary_path.clone())
.unwrap()
.to_string_lossy()
.to_string();
let python_binary_path: String = self
.ensure_python_venv(execution_storage.python_cache_folder_path())
.await?;

log::info!(
"using python from host at path: {:?}",
python_binary_path_at_host.clone()
python_binary_path.clone()
);

// Ensure venv exists at python cache location
let venv_path = execution_storage.python_cache_folder_path();
log::info!("Creating new venv at {:?}", venv_path);
let mut venv_command = tokio::process::Command::new(&python_binary_path_at_host);
venv_command
.args(["-m", "venv", venv_path.to_str().unwrap()])
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.kill_on_drop(true);
let venv_output = venv_command.spawn()?.wait_with_output().await?;
if !venv_output.status.success() {
return Err(anyhow::Error::new(std::io::Error::new(
std::io::ErrorKind::Other,
String::from_utf8(venv_output.stderr)?,
)));
}

// Get pip and python paths from venv
let python_path_at_venv = venv_path
.join(if cfg!(windows) { "Scripts" } else { "bin" })
.join(if cfg!(windows) {
"python.exe"
} else {
"python"
});
let uv_binary_path = path::absolute(self.options.uv_binary_path.clone())
.unwrap()
.to_str()
.unwrap()
.to_string();

let python_binary_path = python_path_at_venv.to_string_lossy().to_string();
let mut ensure_pip_command = tokio::process::Command::new(&python_binary_path);
let mut ensure_pip_command = tokio::process::Command::new(&uv_binary_path);
ensure_pip_command
.args(["-m", "pip", "install", "pipreqs"])
.args(["pip", "install", "pipreqs"])
.env(
"VIRTUAL_ENV",
execution_storage
.python_cache_folder_path()
.to_str()
.unwrap(),
)
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.kill_on_drop(true);
Expand Down Expand Up @@ -456,9 +496,16 @@ print("</shinkai-code-result>")
)));
}

let mut pip_install_command = tokio::process::Command::new(&python_binary_path);
let mut pip_install_command = tokio::process::Command::new(&uv_binary_path);
pip_install_command
.args(["-m", "pip", "install", "-r", "requirements.txt"])
.args(["pip", "install", "-r", "requirements.txt"])
.env(
"VIRTUAL_ENV",
execution_storage
.python_cache_folder_path()
.to_str()
.unwrap(),
)
.current_dir(execution_storage.code_folder_path.clone())
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
Expand Down Expand Up @@ -510,8 +557,14 @@ print("</shinkai-code-result>")
.collect::<Vec<_>>()
.join(","),
);
command.env("SHINKAI_CONTEXT_ID", self.options.context.context_id.clone());
command.env("SHINKAI_EXECUTION_ID", self.options.context.execution_id.clone());
command.env(
"SHINKAI_CONTEXT_ID",
self.options.context.context_id.clone(),
);
command.env(
"SHINKAI_EXECUTION_ID",
self.options.context.execution_id.clone(),
);

if let Some(envs) = envs {
command.envs(envs);
Expand Down
10 changes: 5 additions & 5 deletions libs/shinkai-tools-runner/src/tools/python_runner_options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use super::{
#[derive(Clone)]
pub struct PythonRunnerOptions {
pub context: ExecutionContext,
pub python_binary_path: PathBuf,
pub uv_binary_path: PathBuf,
pub code_runner_docker_image_name: String,
pub force_runner_type: Option<RunnerType>,
pub shinkai_node_location: ShinkaiNodeLocation,
Expand All @@ -18,11 +18,11 @@ impl Default for PythonRunnerOptions {
fn default() -> Self {
Self {
context: ExecutionContext::default(),
code_runner_docker_image_name: String::from("dcspark/shinkai-code-runner:0.9.0"),
python_binary_path: PathBuf::from(if cfg!(windows) {
"C://Users/agall/AppData/Local/Microsoft/WindowsApps/python"
code_runner_docker_image_name: String::from("dcspark/shinkai-code-runner:0.9.1"),
uv_binary_path: PathBuf::from(if cfg!(windows) {
format!("C:\\Users\\{}\\.local\\bin\\uv.exe", whoami::username())
} else {
"python"
format!("/Users/{}/.local/bin/uv", whoami::username())
}),
force_runner_type: None,
shinkai_node_location: ShinkaiNodeLocation {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shinkai_protocol/source",
"version": "0.9.2",
"version": "0.9.3",
"description": "This repository serves as the ecosystem to execute Shinkai tools, provided by the Shinkai team or third-party developers, in a secure environment. It provides a sandboxed space for executing these tools, ensuring that they run safely and efficiently, while also allowing for seamless integration with Rust code.",
"main": "index.js",
"author": "",
Expand Down
Loading