Skip to content

Mixins - Typescript way - Take 1 #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Mixins - Typescript way - Take 1 #1704

merged 2 commits into from
Jul 8, 2020

Conversation

kum-deepak
Copy link
Collaborator

Ref #1703

@kum-deepak kum-deepak added this to the dc-v5 milestone Jul 7, 2020
@kum-deepak
Copy link
Collaborator Author

The entire code now supports basic type checking. All test cases pass. This phase seems done.

@kum-deepak kum-deepak requested a review from gordonwoodhull July 7, 2020 17:24
Copy link
Contributor

@gordonwoodhull gordonwoodhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple of nits, LGTM. I am guessing that you need to add variadic arguments to the mixins, even though they aren't used, in order to make them compatible with Contructor?

@kum-deepak kum-deepak merged commit 6637b91 into dc-js:dc-v5 Jul 8, 2020
@gordonwoodhull
Copy link
Contributor

I'm confused. I didn't think that mixins were a feature of the Typescript language. These are templated functions that return a class, right?

Is it going by the name of the function?

@kum-deepak
Copy link
Collaborator Author

I also did not expect the error message to be so specific. No idea how it is picking it. 😄

@kum-deepak kum-deepak deleted the mixins branch July 11, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants