Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifact triggers and concurrency rules #11327

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 19, 2025

Problem

Artifact checks were not returning the correct results

Solution

Retrigger on any review edits.
Instead of cancelling in progress runs, wait for them to complete
Since this is only triggered on pull-requests we can just use the PR number to ensure the concurrency group is always the same

Validated on internal testing repo PR: https://github.com/dbt-labs/core-action-testing/pull/12

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (e60b41d) to head (915d443).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11327   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         189      189           
  Lines       24169    24169           
=======================================
  Hits        21496    21496           
  Misses       2673     2673           
Flag Coverage Δ
integration 86.27% <ø> (+<0.01%) ⬆️
unit 62.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.53% <ø> (ø)
Integration Tests 86.27% <ø> (+<0.01%) ⬆️

@emmyoop emmyoop marked this pull request as ready for review February 19, 2025 15:25
@emmyoop emmyoop requested a review from a team as a code owner February 19, 2025 15:25
@emmyoop emmyoop merged commit 7bdf27a into main Feb 19, 2025
60 checks passed
@emmyoop emmyoop deleted the er/tweak-triggers branch February 19, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants