Skip to content

Migrate .coveragerc to pyproject.toml section#1743

Merged
rolandwalker merged 1 commit intomainfrom
RW/migrate-coveragerc-to-pyproject-toml
Mar 25, 2026
Merged

Migrate .coveragerc to pyproject.toml section#1743
rolandwalker merged 1 commit intomainfrom
RW/migrate-coveragerc-to-pyproject-toml

Conversation

@rolandwalker
Copy link
Copy Markdown
Contributor

Description

Covered under an existing changelog entry.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 25, 2026
@github-actions
Copy link
Copy Markdown

  1. Regression risk: subprocess coverage startup still points to deleted file
  • In test/features/environment.py:48, COVERAGE_PROCESS_START is still set to .coveragerc, but this PR deletes that file.
  • Impact: behave subprocesses that call coverage.process_startup() can fail to load config (or silently lose intended coverage settings), which can break CI or coverage accounting.
  • Fix: set it to pyproject.toml (or restore a compatibility .coveragerc shim).
  1. Packaging manifest still references removed file
  • MANIFEST.in:2 still includes .coveragerc.
  • Impact: sdist/packaging may emit missing-file warnings and indicates migration is incomplete.
  • Fix: remove .coveragerc from MANIFEST.in.

Missing test coverage

  • There’s no guard test for the behave coverage bootstrap path after this migration. Add a small test asserting the config file referenced by COVERAGE_PROCESS_START exists (or that coverage startup succeeds with the configured path).

@rolandwalker rolandwalker force-pushed the RW/migrate-coveragerc-to-pyproject-toml branch from 0efa2cf to 29650f7 Compare March 25, 2026 20:44
@rolandwalker rolandwalker force-pushed the RW/migrate-coveragerc-to-pyproject-toml branch from 29650f7 to 92580c1 Compare March 25, 2026 20:46
@rolandwalker rolandwalker merged commit 0bf4235 into main Mar 25, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/migrate-coveragerc-to-pyproject-toml branch March 25, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant