Merged
Conversation
--no-show-warnings should override the show_warnings setting in ~/.myclirc. To solve the bug, we need for show_warnings to allow a None value, rather than only a bool. None represents no relevant CLI argument being given.
No security issues found in the introduced diff. Assumption: this review is static; I did not run the db integration tests locally. |
scottnemes
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--no-show-warningsshould override the show_warnings setting in~/.myclirc.I don't think this was introduced by #1732, but that PR was bug-for-bug compatible.
To solve the bug, we need for show_warnings to allow a
Nonevalue, rather than only a bool. None represents no relevant CLI argument being given.Stuffing everything into
connect()isn't great, but this is how other CLI arguments are reconciled with configuration, so it makes sense pending more refactoring ofmain.py.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).