Fix type bug in cors #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are needed as the encryption key can be handed in as a Buffer, a node type.
|
|
dbartholomae
force-pushed
the
fix_type_bug_in_cors
branch
from
fc92f0b to
c335a25
Compare
This solves a type problem related to compose: TypeScript cannot infer generics of composited functions correctly, so we need to get rid of generics to make composition easier. BREAKING CHANGE: Before, JsonSerializer middleware could be used for handler of all kinds of events. Now it can only be used for APIGatewayEvents. This should not cause much trouble, as the middleware already returned APIGatewayResponses only.
This solves a type problem related to compose: TypeScript cannot infer generics of composited functions correctly, so we need to get rid of generics to make composition easier. BREAKING CHANGE: Before, ErrorHandler middleware could be used for handler of all kinds of events. Now it can only be used for APIGatewayEvents. This should not cause much trouble, as the middleware already returned APIGatewayResponses only.
This solves a type problem related to compose: TypeScript cannot infer generics of composited functions correctly, so we need to get rid of generics to make composition easier. BREAKING CHANGE: Before, cors middleware could be used for handler of all kinds of events. Now it can only be used for APIGatewayEvents. This should not cause much trouble, as the middleware already returned APIGatewayResponses only.
This solves a type problem related to compose: TypeScript cannot infer generics of composited functions correctly, so we need to get rid of generics to make composition easier. BREAKING CHANGE: Before, class-validator middleware could be used for handler of all kinds of events. Now it can only be used for APIGatewayEvents. This should not cause much trouble, as the middleware already depended on the body being in the same form as in an APIGatewayEvent.
It doesn't exist.
dbartholomae
force-pushed
the
fix_type_bug_in_cors
branch
from
c335a25 to
52f035b
Compare
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 518 519 +1
Branches 102 98 -4
=========================================
+ Hits 518 519 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36