refactor: enforce screenshot regeneration #4528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-enforce-screenshot-regeneration |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Why was this required? |
because we do have a lot of changes within #4283 that aren't based on the CSS changes being made within that PR. Looked like that our screenshots were outdated. |
nmerget
previously approved these changes
Jul 15, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
added a commit
that referenced
this pull request
Jul 16, 2025
* refactor: enforce screenshot regeneration * auto update snapshots (#4529) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: enforce screenshot regeneration * Revert "refactor: enforce screenshot regeneration" This reverts commit 56a69d5. * Revert "refactor: enforce screenshot regeneration" This reverts commit 910608b. * auto update snapshots (#4530) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * test: updated snapshots * test: updated snapshots * refactor: removed all snapshots to enforce their regeneration * auto update snapshots (#4539) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
enforce regenerating all screenshots.
Types of changes
Further comments