-
Notifications
You must be signed in to change notification settings - Fork 10
chore(deps-dev): bump the playwright group with 3 updates #4331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/dependabot-npm_and_yarn-playwright-0eb18d3974 |
Bumps the playwright group with 3 updates: [@playwright/test](https://github.com/microsoft/playwright), [@playwright/experimental-ct-react](https://github.com/microsoft/playwright) and [@playwright/experimental-ct-vue](https://github.com/microsoft/playwright). Updates `@playwright/test` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) Updates `@playwright/experimental-ct-react` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) Updates `@playwright/experimental-ct-vue` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright - dependency-name: "@playwright/experimental-ct-react" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright - dependency-name: "@playwright/experimental-ct-vue" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright ... Signed-off-by: dependabot[bot] <[email protected]>
cf24795
to
b42f0a8
Compare
Bumps the playwright group with 3 updates: [@playwright/test](https://github.com/microsoft/playwright), [@playwright/experimental-ct-react](https://github.com/microsoft/playwright) and [@playwright/experimental-ct-vue](https://github.com/microsoft/playwright). Updates `@playwright/test` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) Updates `@playwright/experimental-ct-react` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) Updates `@playwright/experimental-ct-vue` from 1.51.1 to 1.52.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.51.1...v1.52.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright - dependency-name: "@playwright/experimental-ct-react" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright - dependency-name: "@playwright/experimental-ct-vue" dependency-version: 1.52.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: playwright ... Signed-off-by: dependabot[bot] <[email protected]>
b42f0a8
to
307daec
Compare
…ht-0eb18d3974' into dependabot-npm_and_yarn-playwright-0eb18d3974
...mium-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml
Show resolved
Hide resolved
@@ -182,5 +182,5 @@ | |||
- combobox "Label" | |||
- status | |||
- text: chevron_down" / " Label | |||
- textbox "Label" | |||
- button "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget the button
role instead of textbox
doesn't seem to be correct to me, does it ?
@@ -180,5 +180,5 @@ | |||
- combobox "Label" | |||
- status | |||
- text: chevron_down" / " Label | |||
- textbox "Label" | |||
- button "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget the button
role instead of textbox
doesn't seem to be correct to me, does it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -182,5 +182,5 @@ | |||
- combobox "Label" | |||
- status | |||
- text: chevron_down" / " Label | |||
- textbox "Label" | |||
- button "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget the button
role instead of textbox
doesn't seem to be correct to me, does it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -182,5 +182,5 @@ | |||
- combobox "Label" | |||
- status | |||
- text: chevron_down" / " Label | |||
- textbox "Label" | |||
- button "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget the button
role instead of textbox
doesn't seem to be correct to me, does it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -182,5 +182,5 @@ | |||
- combobox "Label" | |||
- status | |||
- text: chevron_down" / " Label | |||
- textbox "Label" | |||
- button "Label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget the button
role instead of textbox
doesn't seem to be correct to me, does it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,7 +1,10 @@ | |||
- list: | |||
- listitem: | |||
- link "Test1" | |||
- link "Test1": | |||
- /url: "#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget should those "URLs" remain in here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rn-playwright-0eb18d3974 # Conflicts: # __snapshots__/textarea/showcase/mobile-chrome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png # __snapshots__/tooltip/patternhub/tooltip-properties-should-match-screenshot.png # package-lock.json
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps several Playwright dependencies from v1.51.1 to v1.52.0 and updates the associated snapshot files accordingly.
- Updates snapshot outputs for input, header, and custom-select components to match new Playwright behaviors.
- Removes the checkbox snapshots, indicating a change in how checkbox states are captured or validated.
Reviewed Changes
Copilot reviewed 385 out of 385 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
snapshots/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml | Changed a snapshot entry from a textbox to a button component. |
snapshots/header/showcase/* | Added “[disabled]” flags to disabled link elements across multiple header snapshots. |
snapshots/custom-select/showcase/* | Adjusted snapshot string formatting by appending a colon to link descriptions. |
snapshots/checkbox/showcase/* | Entire checkbox snapshot files have been removed, reflecting a broader update or deprecation. |
Comments suppressed due to low confidence (3)
snapshots/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml:185
- Verify that changing the component type from 'textbox' to 'button' for the 'Label' element is intentional and matches the updated component design.
+ - button "Label"
snapshots/custom-select/showcase/webkit/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml:924
- Confirm that the added colon at the end of the snapshot string is expected according to the new snapshot format.
+ - 'link "Example: Other configuration arrow_up_right\" / \""':
snapshots/checkbox/showcase/webkit/should-have-same-aria-snapshot/DBCheckbox-should-have-same-aria-snapshot.yaml:1
- Ensure that the removal of the checkbox snapshot file is intentional and that any related tests have been updated accordingly.
Entire file deleted
@@ -10,7 +10,7 @@ | |||
- text: x_placeholder" / " | |||
- link "Functional" | |||
- listitem: | |||
- link "Functional disabled" | |||
- link "Functional disabled" [disabled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that adding '[disabled]' to the disabled link entries consistently reflects the updated accessibility standards.
Copilot uses AI. Check for mistakes.
Bumps the playwright group with 3 updates: @playwright/test, @playwright/experimental-ct-react and @playwright/experimental-ct-vue.
Updates
@playwright/test
from 1.51.1 to 1.52.0Release notes
Sourced from
@playwright/test
's releases.Commits
471930b
chore: mark v1.52.0 (#35655)0259acf
cherry-pick(#35637): chore: completely remove annotation warnings codea0fdb3f
cherry-pick(#35633): chore: add v1.52 release notes25fd261
cherry-pick(#35636): chore: fix typos in aria docs6da84b3
cherry-pick(#35373): Revert "chore: add location named property to annotation...2914d1b
cherry-pick(#35613): chore: refactor error context (#35613)5465ffb
cherry-pick(#35603): chore: temporarily disable floating promise warning mess...76ee48d
chore: followup on static annotations (#35579)d79bb57
chore(bidi): rename bidi-firefox-stable to moz-firefox channel (#35611)6262a12
chore: retry selecting option for the notconnected case (#35610)Maintainer changes
This version was pushed to npm by playwright-bot, a new releaser for
@playwright/test
since your current version.Updates
@playwright/experimental-ct-react
from 1.51.1 to 1.52.0Release notes
Sourced from
@playwright/experimental-ct-react
's releases.Commits
471930b
chore: mark v1.52.0 (#35655)0259acf
cherry-pick(#35637): chore: completely remove annotation warnings codea0fdb3f
cherry-pick(#35633): chore: add v1.52 release notes25fd261
cherry-pick(#35636): chore: fix typos in aria docs6da84b3
cherry-pick(#35373): Revert "chore: add location named property to annotation...2914d1b
cherry-pick(#35613): chore: refactor error context (#35613)5465ffb
cherry-pick(#35603): chore: temporarily disable floating promise warning mess...76ee48d
chore: followup on static annotations (#35579)d79bb57
chore(bidi): rename bidi-firefox-stable to moz-firefox channel (#35611)6262a12
chore: retry selecting option for the notconnected case (#35610)Maintainer changes
This version was pushed to npm by playwright-bot, a new releaser for
@playwright/experimental-ct-react
since your current version.Updates
@playwright/experimental-ct-vue
from 1.51.1 to 1.52.0Release notes
Sourced from
@playwright/experimental-ct-vue
's releases.Commits
471930b
chore: mark v1.52.0 (#35655)0259acf
cherry-pick(#35637): chore: completely remove annotation warnings codea0fdb3f
cherry-pick(#35633): chore: add v1.52 release notes25fd261
cherry-pick(#35636): chore: fix typos in aria docs6da84b3
cherry-pick(#35373): Revert "chore: add location named property to annotation...2914d1b
cherry-pick(#35613): chore: refactor error context (#35613)5465ffb
cherry-pick(#35603): chore: temporarily disable floating promise warning mess...76ee48d
chore: followup on static annotations (#35579)d79bb57
chore(bidi): rename bidi-firefox-stable to moz-firefox channel (#35611)6262a12
chore: retry selecting option for the notconnected case (#35610)Maintainer changes
This version was pushed to npm by playwright-bot, a new releaser for
@playwright/experimental-ct-vue
since your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions