Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with tabs and accordion for react 19 #4030

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Apr 7, 2025

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner April 7, 2025 13:11
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Apr 7, 2025
@nmerget nmerget enabled auto-merge (squash) April 7, 2025 13:22
mfranzke
mfranzke previously approved these changes Apr 7, 2025
@mfranzke mfranzke self-assigned this Apr 7, 2025
@mfranzke mfranzke requested a review from Copilot April 7, 2025 13:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • showcases/next-showcase/package.json: Language not supported
  • showcases/patternhub/package.json: Language not supported
  • showcases/react-showcase/package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/components/src/components/accordion-item/accordion-item.lite.tsx:73

  • Rather than using @ts-ignore to bypass TypeScript errors when setting the name attribute, consider properly typing the ref to handle the attribute assignment without suppressing type checks.
/* @ts-ignore */

@github-actions github-actions bot removed the 📺showcases Changes to 1-n showcases label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants