fix: issue with tabs and accordion for react 19 #4030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json
github-actions
bot
added
🧱components
mfranzke
previously approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- showcases/next-showcase/package.json: Language not supported
- showcases/patternhub/package.json: Language not supported
- showcases/react-showcase/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/components/src/components/accordion-item/accordion-item.lite.tsx:73
- Rather than using @ts-ignore to bypass TypeScript errors when setting the name attribute, consider properly typing the ref to handle the attribute assignment without suppressing type checks.
/* @ts-ignore */
packages/components/src/components/accordion-item/accordion-item.lite.tsx
Show resolved
Hide resolved
packages/components/src/components/accordion-item/accordion-item.lite.tsx
Show resolved
Hide resolved
packages/components/src/components/accordion-item/accordion-item.lite.tsx
Show resolved
Hide resolved
michaelmkraus
approved these changes
Apr 14, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Further comments