Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: native select styling #4017

Open
wants to merge 6 commits into
base: feat-multi-select
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Apr 4, 2025

Proposed changes

Provide a styling for the native select elements options

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Apr 4, 2025
@mfranzke mfranzke self-assigned this Apr 4, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner April 4, 2025 04:46
Copy link
Contributor

github-actions bot commented Apr 4, 2025

@mfranzke mfranzke changed the title feat: multi select native select styling feat: native select styling Apr 4, 2025
@mfranzke mfranzke requested a review from Copilot April 4, 2025 09:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/components/src/components/select/select.scss: Language not supported
Comments suppressed due to low confidence (2)

packages/components/src/components/select/select.lite.tsx:211

  • Verify that rendering props.placeholder in the hidden option correctly supports accessibility and intended display, particularly when props.placeholder might be undefined.
<option hidden>{props.placeholder}</option>

packages/components/src/components/select/select.lite.tsx:212

  • Confirm that using the component with else={props.children} properly replaces the previously rendered props.children and meets the design requirements for fallback content.
<Show when={props.options} else={props.children}>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄🆙improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant