-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native select styling #4017
base: feat-multi-select
Are you sure you want to change the base?
feat: native select styling #4017
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-multi-select-native-select-styling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- packages/components/src/components/select/select.scss: Language not supported
Comments suppressed due to low confidence (2)
packages/components/src/components/select/select.lite.tsx:211
- Verify that rendering props.placeholder in the hidden option correctly supports accessibility and intended display, particularly when props.placeholder might be undefined.
<option hidden>{props.placeholder}</option>
packages/components/src/components/select/select.lite.tsx:212
- Confirm that using the component with else={props.children} properly replaces the previously rendered props.children and meets the design requirements for fallback content.
<Show when={props.options} else={props.children}>
Proposed changes
Provide a styling for the native select elements options
Types of changes
Further comments