Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: foundation update #4002

Open
wants to merge 10 commits into
base: 2.0.0-release
Choose a base branch
from
Open

feat: foundation update #4002

wants to merge 10 commits into from

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Apr 2, 2025

Proposed changes

  • Add new properties for foundations (colors)
  • Removed --db-type-line-height/-font-size variables
  • Fixed some minor issues in components referencing old --db-type-line-height/-font-size variables

closes #3926
closes #3924

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner April 2, 2025 15:04
@nmerget nmerget marked this pull request as draft April 2, 2025 15:04
@mfranzke mfranzke changed the title Feat foundation update feat: foundation update Apr 2, 2025
@mfranzke mfranzke requested a review from Copilot April 4, 2025 09:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 26 out of 45 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • packages/components/src/components/button/button.scss: Language not supported
  • packages/components/src/components/notification/notification.scss: Language not supported
  • packages/components/src/components/select/select.scss: Language not supported
  • packages/components/src/components/switch/switch.scss: Language not supported
  • packages/components/src/styles/internal/_form-components.scss: Language not supported
  • packages/foundations/dev/colors.html: Language not supported
  • packages/foundations/dev/fonts.html: Language not supported
  • packages/foundations/dev/icons.html: Language not supported
  • packages/foundations/dev/index.css: Language not supported
  • packages/foundations/scss/_screen-sizes.scss: Language not supported
  • packages/foundations/scss/absolute.scss: Language not supported
  • packages/foundations/scss/colors/_default-color-icons.scss: Language not supported
  • packages/foundations/scss/colors/_placeholder.scss: Language not supported
  • packages/foundations/scss/colors/_variables.scss: Language not supported
  • packages/foundations/scss/colors/speaking-colors/additional/_blue.speaking-colors.scss: Language not supported
  • packages/foundations/scss/colors/speaking-colors/additional/_cyan.speaking-colors.scss: Language not supported
  • packages/foundations/scss/colors/speaking-colors/additional/_green.speaking-colors.scss: Language not supported
  • packages/foundations/scss/colors/speaking-colors/additional/_orange.speaking-colors.scss: Language not supported
  • packages/foundations/scss/colors/speaking-colors/additional/_pink.speaking-colors.scss: Language not supported
Comments suppressed due to low confidence (1)

packages/foundations/scripts/local/generate-icon-overview.ts:19

  • The new stylesheet reference points to '/dev/index.css', which appears to be a development asset. Please confirm that this reference is intentional for production usage.
<link rel="stylesheet" href="/dev/index.css" />

@nmerget nmerget marked this pull request as ready for review April 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant