-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added merge groups #3896
base: main
Are you sure you want to change the base?
feat: added merge groups #3896
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-added-merge-groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for triggering GitHub Actions workflows on merge group events as part of the new merge groups feature.
- Added merge_group event triggers to pull-request, pull-request-opened, and default workflow definitions.
- Configured branch filtering for merge group events in pull-request and pull-request-opened workflows.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/pull-request.yml | Adds merge_group trigger with branch filtering for PR events |
.github/workflows/pull-request-opened.yml | Adds merge_group trigger with branch filtering for opened PRs |
.github/workflows/default.yml | Adds merge_group event trigger but without branch filtering |
@@ -3,6 +3,7 @@ name: Default Pipeline | |||
|
|||
on: | |||
pull_request: | |||
merge_group: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge_group event trigger is added without branch filtering, unlike in the other workflows. Consider adding a branch specification (e.g., branches: ["main"]) to ensure consistency.
merge_group: | |
merge_group: | |
branches: | |
- "main" |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Proposed changes
according to https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions
and
setting upactivating a new ruleset for merge groups, as documented: https://github.com/db-ux-design-system/core-web/settings/rules/3944111We should additionally have a look at https://github.com/googleapis/release-please as well.
Types of changes
Further comments