Skip to content

accept trailing comma #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

yagince
Copy link
Contributor

@yagince yagince commented Feb 15, 2019

Hi

I want to use it in the following writing style, I tried to allow the trailing comma

    assert_json_include! (
        actual: json! ({"a": {"b": true}}),
        expected: json! ({"a": {}}),
    );

What do you think?

Copy link
Owner

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This totally should work of course. Thanks for fixing it 😊

@davidpdrsn davidpdrsn merged commit 701409b into davidpdrsn:master Feb 15, 2019
@davidpdrsn
Copy link
Owner

This was just released as version 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants