Add Payment Request button for Apple Pay and Google Pay #1175
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stripe.createToken(ev.paymentMethod).then(function (result) { | ||
| if (result.error) { | ||
| renderError(result.error.message); | ||
| ev.complete('fail'); | ||
| } else { |
There was a problem hiding this comment.
When Apple Pay/Google Pay is available, the new Payment Request handler listens for the paymentmethod event and passes ev.paymentMethod to stripe.createToken. Stripe.js only accepts an Element or token type there, so the promise comes back with an error and stripeToken is never populated, while the server-side signup POST still rejects requests without a stripeToken. The Payment Request button will therefore always fail instead of submitting a subscription; it needs to use the token event or a PaymentIntent flow rather than createToken(ev.paymentMethod).
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task