gccutils: get pretty-printing working again #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new function ``gcc.is_cplusplus`` to determine if we are compiling C++ * Use ``gcc.is_cplusplus`` in gccutils to not iterate over fullname when we are not using C++ (resolves davidmalcolm#72) * Allow accessing ``gcc.Type.sizeof`` to raise a TypeError while pretty-printing to be silently ignored and not added to attributes * Use ``pp_newline_and_flush`` instead of ``pp_newline`` in ``PyGccPrettyPrinter_as_string`` when we are using GCC 5.3 or later (as this provides the historic functionality relied upon)
|
ping! |
|
Hi, is this project still being mantained? I sent this pull request over two years ago and haven't heard back. Can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function
gcc.is_cplusplusto determine if we arecompiling C++
Use
gcc.is_cplusplusin gccutils to not iterate over fullnamewhen we are not using C++ (resolves RuntimeError: attribute 'fullname' is only available when compiling C++ code #72)
Allow accessing
gcc.Type.sizeofto raise a TypeError whilepretty-printing to be silently ignored and not added to attributes
Use
pp_newline_and_flushinstead ofpp_newlineinPyGccPrettyPrinter_as_stringwhen we are using GCC 5.3 orlater (as this provides the historic functionality relied upon)