Skip to content

Adds support to other invoice types and minor update to README #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds support to other invoice types and minor update to README #33

wants to merge 2 commits into from

Conversation

darwintantuco
Copy link

  • Adds support for other invoice types:
    • invoice service
    • invoice professional
    • invoice time billing

(I follow current naming convention, similar to InvoiceItem)

  • Update docs to explicitly include redirect uri when creating myob client
    Encountered invalid_request error when running myob_client.get_access_code_url.
    Found out that redirect_uri is needed.
    It would be nice to see this in README.

@darwintantuco darwintantuco mentioned this pull request Jan 4, 2021
Closed
@darwintantuco
Copy link
Author

would be nice if someone can check this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@darwintantuco