Skip to content

feat(array): introducing BTreeMap conversion and refactoring HashMap conversion #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(array): introducing BTreeMap conversion and refactoring HashMap conversion #535

wants to merge 1 commit into from

Conversation

kakserpom
Copy link
Contributor

Description

I've added the same FromZval/IntoZval conversions for BTreeMap that exist for HashMap.

I know a doc update wouldn't hurt, but I am too preoccupied with development atm.

@kakserpom kakserpom mentioned this pull request Jul 20, 2025
Closed
@coveralls
Copy link

coveralls commented Jul 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16403230036

Details

  • 0 of 20 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 27.026%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/conversions/hash_map.rs 0 2 0.0%
src/types/array/conversions/btree_map.rs 0 18 0.0%
Totals Coverage Status
Change from base Build 16402371513: -0.1%
Covered Lines: 1127
Relevant Lines: 4170
💛 - Coveralls

ptondereau
ptondereau approved these changes Jul 20, 2025
View reviewed changes
Copy link
Collaborator

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would it be possible to have some tests?

@Xenira
Copy link
Collaborator

Xenira commented Jul 20, 2025

Also could you elaborate on this? #520 (comment)

@kakserpom kakserpom force-pushed the array_btreemap_conversion_2 branch from 9dbd1b1 to bd65d8a Compare July 20, 2025 18:55
@kakserpom kakserpom force-pushed the array_btreemap_conversion_2 branch from bd65d8a to 08bfe39 Compare July 20, 2025 19:03
@kakserpom
Copy link
Contributor Author

@Xenira

Also could you elaborate on this? #520 (comment)

I've implemented your suggestion. I've also fixed the cause of clippy::implicit_hasher warning in hash_map by generalizing the hasher.

@kakserpom
Copy link
Contributor Author

LGTM but would it be possible to have some tests?

What's there to test? Rustc does the job pretty well :)

@kakserpom kakserpom changed the title feat(array): BTreeMap conversion feat(array): introducing BTreeMap conversion and refactoring HashMap conversion Jul 20, 2025
@ptondereau
Copy link
Collaborator

LGTM but would it be possible to have some tests?

What's there to test? Rustc does the job pretty well :)

Just ensuring the conversion if it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptondereau ptondereau ptondereau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kakserpom @coveralls @Xenira @ptondereau