Add helpers for Zval coercion #341
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakserpom
reviewed
Jun 20, 2025
| self.set_string(if val { "1" } else { "0" }, false)?; | ||
| return Ok(()); | ||
| } else if self.is_array() { | ||
| self.set_string("Array", false)?; |
There was a problem hiding this comment.
➜ ~ php -r '(string)[];'
PHP Warning: Array to string conversion in Command line code on line 1
So I'd suggest removing this.
kakserpom
reviewed
Jun 20, 2025
| self.set_bool(val != "0" && val != ""); | ||
| return Ok(()); | ||
| } else if let Some(val) = self.array() { | ||
| self.set_bool(val.len() != 0); |
kakserpom
reviewed
Jun 20, 2025
| self.set_long(val.parse::<i64>().map_err(|_| Error::ZvalConversion(self.get_type()))?); | ||
| return Ok(()); | ||
| } else if let Some(val) = self.array() { | ||
| self.set_long(if val.len() > 0 { 1 } else { 0 }); |
kakserpom
reviewed
Jun 20, 2025
| self.set_double(val.parse::<f64>().map_err(|_| Error::ZvalConversion(self.get_type()))?); | ||
| return Ok(()); | ||
| } else if let Some(val) = self.array() { | ||
| self.set_double(if val.len() > 0 { 1.0 } else { 0.0 }); |
Xenira
force-pushed
the
coercion-helpers
branch
2 times, most recently
from
bd2ffeb to
cfb15cb
Compare
Pull Request Test Coverage Report for Build 15784055444Details
💛 - Coveralls |
|
Had a look at this. Don't know if i like that the Would also need some tests. |
|
Btw, it would be nice to call __to_string() on objects if it's present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.