Skip to content

fix: Allow to initialise objects #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Allow to initialise objects #313

wants to merge 2 commits into from

Conversation

cv65kr
Copy link

@cv65kr cv65kr commented Mar 7, 2024

Solves: #262

@ptondereau
Copy link
Collaborator

@cv65kr thanks for the PR!
Could you, please rebase on master for the CI?

@cv65kr cv65kr force-pushed the fix/initialisation-objects branch from 31d4727 to 2cf7c66 Compare October 25, 2024 11:04
@cv65kr
Copy link
Author

cv65kr commented Oct 25, 2024

@ptondereau done

@Xenira
Copy link
Collaborator

Xenira commented Oct 25, 2024

@cv65kr guess you need to run cargo fmt

@cv65kr
Copy link
Author

cv65kr commented Oct 25, 2024

@Xenira fixed

@Xenira
Copy link
Collaborator

Xenira commented Oct 25, 2024

LGTM, would like someone with more knowledge of php internals to have a look.

@Xenira Xenira requested a review from ptondereau October 25, 2024 17:15
alekitto added a commit to alekitto/ext-php-rs that referenced this pull request Jun 2, 2025
@alekitto
fix: fixed object access in object write/read/has_property handlers
e62bb40 
Partially derived from davidcole1340#313, this commit fixes access to object
properties from Rust code. This is needed to correctly initialize
exception objects.
alekitto added a commit to alekitto/ext-php-rs that referenced this pull request Jun 4, 2025
@alekitto
fix: fixed object access in object write/read/has_property handlers
c46ed7a 
Partially derived from davidcole1340#313, this commit fixes access to object
properties from Rust code. This is needed to correctly initialize
exception objects.
@alekitto alekitto mentioned this pull request Jun 4, 2025
Merged
Xenira pushed a commit to alekitto/ext-php-rs that referenced this pull request Jun 5, 2025
@alekitto @Xenira
fix: fixed object access in object write/read/has_property handlers
498d7bb 
Partially derived from davidcole1340#313, this commit fixes access to object
properties from Rust code. This is needed to correctly initialize
exception objects.
Xenira pushed a commit that referenced this pull request Jun 5, 2025
@alekitto
fix: fix object access in object write/read/has_property handlers
96555c4 
Partially derived from #313, this commit fixes access to object
properties from Rust code. This is needed to correctly initialise
exception objects.

Refs: #313, #438
@Xenira
Copy link
Collaborator

Xenira commented Jun 5, 2025

Resolved by #438

Sorry @cv65kr was new in the project when this came up and then lost sight of it. I still want to say thank you for contributing.

@Xenira Xenira closed this Jun 5, 2025
@davidcole1340 davidcole1340 mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptondereau ptondereau Awaiting requested review from ptondereau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cv65kr @ptondereau @Xenira