Skip to content

Issue/569 start task updater removes all #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hhund wants to merge 3 commits into
base: develop
Choose a base branch
from
+650 −9
Open

Issue/569 start task updater removes all #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f928e7b
added tests to reproduce 'removeOutput removes all' issue
hhund Aug 18, 2026
fed436a
removed unused method parameter
hhund Aug 18, 2026
ef7ae64
Removed optional version code; only system/code/version outputs allowed
hhund Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ...sf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/service/StartTaskUpdaterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ public StartTaskUpdaterImpl(DsfClientProvider dsfClientProvider, Supplier<Task>
@Override
public void addOutput(Coding outputType, Type outputValue)
{
checkOutputType(outputType);

Task task = getStartTask.get();
task.addOutput().setValue(outputValue).getType().addCoding(outputType);

Expand All @@ -64,16 +66,15 @@ public Optional<TaskOutputComponent> getOutput(Coding outputType)

private Optional<TaskOutputComponent> doGetOutput(Task task, Coding outputType)
{
return task.getOutput().stream().filter(matchesSystemAndCodeOptionallyVersion(outputType)).findFirst();
return task.getOutput().stream().filter(matchesSystemCodeAndVersion(outputType)).findFirst();
}

private Predicate<TaskOutputComponent> matchesSystemAndCodeOptionallyVersion(Coding outputType)
private Predicate<TaskOutputComponent> matchesSystemCodeAndVersion(Coding outputType)
{
return o -> o.getType().getCoding().stream()
.anyMatch(c -> Objects.equals(c.getSystem(), outputType.getSystem())
&& Objects.equals(c.getCode(), outputType.getCode()) && outputType.hasVersion()
? Objects.equals(c.getVersion(), outputType.getVersion())
: true);
&& Objects.equals(c.getCode(), outputType.getCode())
&& Objects.equals(c.getVersion(), outputType.getVersion()));
}

@Override
Expand All @@ -85,8 +86,7 @@ public void modifyOutput(Coding outputType, Type outputValue)

doGetOutput(task, outputType)
.orElseThrow(() -> new IllegalArgumentException("Output for type " + outputType.getSystem() + "|"
+ outputType.getCode()
+ (outputType.hasVersion() ? " (version: " + outputType.getVersion() + ") not found" : "")))
+ outputType.getCode() + " (version: " + outputType.getVersion() + ") not found"))
.setValue(outputValue);

Task updated = dsfClientProvider.getLocal().update(task);
Expand All @@ -101,11 +101,11 @@ public void removeOutput(Coding outputType)
Task task = getStartTask.get();

List<TaskOutputComponent> filtered = task.getOutput().stream()
.filter(matchesSystemAndCodeOptionallyVersion(outputType).negate()).toList();
.filter(matchesSystemCodeAndVersion(outputType).negate()).toList();

if (task.getOutput().size() == filtered.size())
throw new IllegalArgumentException("Output for type " + outputType.getSystem() + "|" + outputType.getCode()
+ (outputType.hasVersion() ? " (version: " + outputType.getVersion() + ") not found" : ""));
+ " (version: " + outputType.getVersion() + ") not found");

task.setOutput(filtered);

Expand Down
Loading
Loading