[BUZZOK-27814] Install extra agent dependecies in runtime. #1716
Conversation
| RUN . ${VENV_PATH}/bin/activate && \ | ||
| uv sync | ||
| uv sync && \ | ||
| chmod -R 777 ${VENV_PATH} |
There was a problem hiding this comment.
Venv should be writable both for notebook user (10101) and custom model user (1000).
| ARG VENV_PATH | ||
|
|
||
| COPY ./pyproject.toml ${WORKDIR}/pyproject.toml | ||
| COPY ./uv.lock ${WORKDIR}/uv.lock |
There was a problem hiding this comment.
We didn't use lock file, but it's better to have it for consistency of env.
| # this stage has only bare minimal of dependencies installed to optimize build time for the local development | ||
|
|
||
| ENV ANNOY_COMPILER_ARGS="-D_CRT_SECURE_NO_WARNINGS,-DANNOYLIB_MULTITHREADED_BUILD,-march=x86-64" | ||
| ENV UV_COMPILE_BYTECODE=1 \ |
There was a problem hiding this comment.
Env variables are not passed between docker stages, so need to explicitly enable bytecode compilation again for uv sync.
| [dependency-groups] | ||
| extras = [] |
There was a problem hiding this comment.
Extra user dependencies will go here.
There was a problem hiding this comment.
I think this work well to put it here. We should update the templates pyproject.toml everywhere to have this addition
There was a problem hiding this comment.
Yep, working on another PR do do the same changes in af-component-agent.
| # This file was autogenerated by uv via the following command: | ||
| # uv pip compile --no-annotate --no-emit-index-url --no-emit-trusted-host --output-file=requirements.txt pyproject.toml |
There was a problem hiding this comment.
uv lock
uv sync
uv pip freeze > requirements.txt
|
The Needs Review labels were added based on the following file changes. Team @datarobot/buzok (#genai) was assigned because of changes in files:public_dropin_environments/python311_genai_agents/Dockerfile public_dropin_environments/python311_genai_agents/Dockerfile.local public_dropin_environments/python311_genai_agents/env_info.json public_dropin_environments/python311_genai_agents/pyproject.toml public_dropin_environments/python311_genai_agents/requirements.txt public_dropin_environments/python311_genai_agents/run_agent.py public_dropin_environments/python311_genai_agents/start_server_drum.sh public_dropin_environments/python311_genai_agents/uv.lock If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
|
Label Needs Review: GenAI Tooling (Buzok) was removed because @tsdaemon is part of Generative AI Tooling domain. |
| ARG VENV_PATH | ||
|
|
||
| COPY ./pyproject.toml ${WORKDIR}/pyproject.toml | ||
| COPY ./uv.lock ${WORKDIR}/uv.lock |
There was a problem hiding this comment.
If the user doesn't have a uv.lock file would this be a problem? Say they just to a task start + task deploy, they might not have built a local environment. They "must" have a pyproject.toml, but the uv.lock could be missing
There was a problem hiding this comment.
This particular uv.lock is part of execution env (I've added it).
If we are talking about agent itself:
uv syncis non-critical - we would still attempt to run the agent.uv.lockis generally supposed to be always present because recommended way to add dependency would be viauv add --no-upgrade --group extras <dependency>or via some Task shortcut. Manual editing ofpyproject.tomlis not recommended (unless you know what you are doing).
There was a problem hiding this comment.
if you mean that uv.lock may be missing when building docker image locally using Dockerfile.local - I guess it's okay to require user to freeze env by generating lock file in this case. Lock file is generally a must in image if we're talking about consistency of dependencies.
There was a problem hiding this comment.
Yea, thats fair. If you make a ticket or two for updating docks related to this I can help pickup recipe and agent updates next week. I know you'll be out soon.
There was a problem hiding this comment.
To your second comment I think that makes sense
rmidianyi
changed the title
4 participants
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Adds support for installing extra dependencies for an agent in runtime to improve iteration speed during agent development (image rebuild is no required now):
extrasgroup in agent'spyproject.toml.run_agent.py) or when LRS is started during deployment (start_server_drum.sh).Caveats
Codespace:
Custom Model:
