Skip to content

Conversation

@nglmercer
Copy link

before:

PS C:\Users\mm\Documents\GitHub\core> go build -o core.exe -trimpath
PS C:\Users\mm\Documents\GitHub\core> ./core.exe
ts=2025-11-21T16:25:52Z level=INFO component="Core" application="datarhei-core" arch="windows/amd64" compiler="go1.25.0" license="Apache License Version 2.0" repository="https://github.com/datarhei/core" version="16.16.0"
ts=2025-11-21T16:25:52Z level=INFO component="Core" msg="Read config file" path="./config/config.json"
ts=2025-11-21T16:25:52Z level=ERROR component="Config" description="RTMP app for publishing" env="CORE_RTMP_APP" error="\\ is not an absolute path" override=false value="\\" variable="rtmp.app"
ts=2025-11-21T16:25:52Z level=ERROR component="Config" description="Path to ffmpeg binary" env="CORE_FFMPEG_BINARY" error="ffmpeg not 
found or is not executable" override=false value="ffmpeg" variable="ffmpeg.binary"
ts=2025-11-21T16:25:52Z level=ERROR component="Core" error="Not all variables are set or are valid. Check the error messages above. Bailing out."
ts=2025-11-21T16:25:52Z level=ERROR component="Core" msg="Failed to create new API" error="not all variables are set or valid"  

after build:

PS C:\Users\mm\Documents\GitHub\core> ./core.exe
ts=2025-11-21T17:23:48Z level=INFO component="Core" application="datarhei-core" arch="windows/amd64" compiler="go1.25.0" license="Apache License Version 2.0" repository="https://github.com/datarhei/core" version="16.16.0"
ts=2025-11-21T17:23:48Z level=INFO component="Core" msg="Read config file" path="./config/config.json"
ts=2025-11-21T17:23:49Z level=INFO component="HTTP" msg="Server started" address=":8080"

- Switch API reload to `NewRootedDiskFilesystem(Root: ".")` for cwd-relative ops
- Use `NewString` for RTMP.App/FFmpeg.Binary (drop absolute/exec enforcement)
- Remove absolute path resolution in JSON config store
- Improve `diskFilesystem.LookPath`: use `filepath.IsAbs`, add Windows `.exe` suffix
- Simplify FFmpeg skills init error handling

Allows portable execution from any dir (e.g., containers), fixes Windows compat.
@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant