Skip to content

CI - Scope the Azure log shipping test databases by run id so concurrent runs do not share a blob name #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potatoqualitee merged 1 commit into from
Sep 19, 2026
+6 −2
Merged

CI - Scope the Azure log shipping test databases by run id so concurrent runs do not share a blob name #10717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/scripts/gh-actions.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,10 @@ END
$cred = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList "sqladmin", $password

$azureUrl = "https://dbatools.blob.core.windows.net/dbatools"
$dbName = "dbatoolsci_logship_azure"
# The database name is part of the blob name, and the container is shared by every run on every branch.
# Scoping it by run id and attempt keeps two runs that reach this backup within the same second from
# fighting over one blob (#10667). The cleanup below lists by this prefix, so it still finds its own blobs.
$dbName = "dbatoolsci_logship_azure_$($env:GITHUB_RUN_ID)_$($env:GITHUB_RUN_ATTEMPT)"

# Create SAS token credential on both instances
$primaryServer = Connect-DbaInstance -SqlInstance localhost -SqlCredential $cred
Expand Down Expand Up @@ -507,7 +510,8 @@ END
It -Skip:(-not $env:azurepasswd) "adds a second live secondary without replacing the Azure primary configuration" {
$PSDefaultParameterValues.Clear()
$azureUrl = "https://dbatools.blob.core.windows.net/dbatools"
$dbName = "dbatoolsci_logship_addsecondary"
# Scoped by run id and attempt for the same reason as the SAS token test above (#10667).
$dbName = "dbatoolsci_logship_addsecondary_$($env:GITHUB_RUN_ID)_$($env:GITHUB_RUN_ATTEMPT)"
$secondDbName = "${dbName}_second"
$missingPrimaryDbName = "${dbName}_missing"
$sasToken = $env:azurepasswd.TrimStart("?")
Expand Down