Skip to content

Invoke-DbaDbDataMasking - Fix StaticValue empty string fallback and FilterQuery in Actions #10281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreasjordan wants to merge 1 commit into
base: development
Choose a base branch
from
+11 −2
Open

Invoke-DbaDbDataMasking - Fix StaticValue empty string fallback and FilterQuery in Actions #10281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions public/Invoke-DbaDbDataMasking.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ function Invoke-DbaDbDataMasking {
$newValue = $null

# Handle static values
if ($columnobject.StaticValue) {
if ($null -ne $columnobject.StaticValue) {
$newValue = $columnobject.StaticValue

if ($null -eq $newValue -and -not $columnobject.Nullable) {
Expand Down Expand Up @@ -904,7 +904,7 @@ function Invoke-DbaDbDataMasking {
}

# If we haven't determined a value yet, generate one
if ($null -eq $newValue -and -not $columnobject.StaticValue) {
if ($null -eq $newValue -and $null -eq $columnobject.StaticValue) {
# make sure min is good
if ($columnobject.MinValue) {
$min = $columnobject.MinValue
Expand Down Expand Up @@ -1149,6 +1149,15 @@ function Invoke-DbaDbDataMasking {
}
}
}
# Add FilterQuery WHERE clause to restrict which rows are updated
if ($validAction -and $tableobject.FilterQuery) {
$filterParts = ($tableobject.FilterQuery) -split "WHERE", 2, "ignorecase"
if ($filterParts.Count -gt 1) {
$filterWhereClause = $filterParts[1].Trim().TrimEnd(";")
$query = $query.TrimEnd(";") + " WHERE $filterWhereClause;"
}
}

# Add the query to the rest
if ($validAction) {
$null = $stringBuilder.AppendLine($query)
Expand Down
Loading