Skip to content

Get-DbaDbOrphanUser - Skip SQL login orphan check for contained databases #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreasjordan wants to merge 1 commit into
base: development
Choose a base branch
from
+11 −1
Open

Get-DbaDbOrphanUser - Skip SQL login orphan check for contained databases #10270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion public/Get-DbaDbOrphanUser.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ function Get-DbaDbOrphanUser {
.DESCRIPTION
An orphan user is defined by a user that does not have their matching login. (Login property = "").

Note: Users in contained databases (Partial or Full containment type) are not considered orphaned for SQL logins,
as these users authenticate directly to the database without requiring a server-level login.
Windows users are still checked for orphaned status regardless of containment type.

.PARAMETER SqlInstance
The target SQL Server instance or instances.

Expand Down Expand Up @@ -107,7 +111,13 @@ function Get-DbaDbOrphanUser {
try {
Write-Message -Level Verbose -Message "Validating users on database '$db'."
$UsersToWork = @()
$UsersToWork += $db.Users | Where-Object { ($_.Login -eq "") -and ($_.ID -gt 4) -and ($_.Sid.Length -eq 16) -and ($_.LoginType -in 'SqlLogin', 'Certificate') }
# In contained databases (Partial or Full), SQL users authenticate directly to the database
# without requiring a server-level login, so they are not considered orphaned
if ($db.ContainmentType.ToString() -eq "None") {
$UsersToWork += $db.Users | Where-Object { ($_.Login -eq "") -and ($_.ID -gt 4) -and ($_.Sid.Length -eq 16) -and ($_.LoginType -in 'SqlLogin', 'Certificate') }
} else {
Write-Message -Level Verbose -Message "Skipping SQL login orphan check on contained database '$db' (ContainmentType: $($db.ContainmentType))."
}
$UsersToWork += $db.Users | Where-Object { ($_.Login -notin $server.Logins.Name) -and ($_.ID -gt 4) -and ($_.Sid.Length -gt 16 -and $_.LoginType -in 'WindowsUser', 'WindowsGroup') }
if ($UsersToWork.Count -gt 0) {
Write-Message -Level Verbose -Message "Orphan users found"
Expand Down
Loading